From: Anselm R. Garbe Date: Thu, 10 May 2007 11:47:44 +0000 (+0200) Subject: fixed a potential security flaw X-Git-Url: https://git.danieliu.xyz/?a=commitdiff_plain;h=b8bccb4ac5222a01ecd6a5f82997ea2ee3b84b8b;p=dwm.git fixed a potential security flaw --- diff --git a/client.c b/client.c index 03d158f..64da343 100644 --- a/client.c +++ b/client.c @@ -365,16 +365,18 @@ updatetitle(Client *c) { XGetWMName(dpy, c->win, &name); if(!name.nitems) return; - if(name.encoding == XA_STRING) - strncpy(c->name, (char *)name.value, sizeof c->name); + if(name.encoding == XA_STRING) { + strncpy(c->name, (char *)name.value, sizeof c->name - 1); + } else { if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success && n > 0 && *list) { - strncpy(c->name, *list, sizeof c->name); + strncpy(c->name, *list, sizeof c->name - 1); XFreeStringList(list); } } + c->name[sizeof c->name - 1] = '\0'; XFree(name.value); }