From: alp@alexpilon.ca <alp@alexpilon.ca>
Date: Tue, 21 Apr 2015 14:27:51 +0000 (+0200)
Subject: Make build shut up about system() without return value check.
X-Git-Url: https://git.danieliu.xyz/?a=commitdiff_plain;h=742a41d6554ce1848f45ea89cb83d62c7e881352;p=st.git

Make build shut up about system() without return value check.

    st.c:1321:2: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
            system(cmd);
            ^~~~~~ ~~~

Debatable whether an error here should case exit(EXIT_FAILURE). Just
preserving the existing behaviour for now.
---

diff --git a/st.c b/st.c
index 8e51344..b042be2 100644
--- a/st.c
+++ b/st.c
@@ -1276,7 +1276,8 @@ stty(void)
 		siz-= n + 1;
 	}
 	*q = '\0';
-	system(cmd);
+	if (system(cmd) != 0)
+	    perror("Couldn't call stty");
 }
 
 void