From: Connor Lane Smith <cls@lubutu.com>
Date: Thu, 23 Jun 2011 19:04:50 +0000 (+0100)
Subject: lsx: check snprintf
X-Git-Url: https://git.danieliu.xyz/?a=commitdiff_plain;h=88d44169e9ea6c208412691c5767edca32718472;p=dmenu.git

lsx: check snprintf
---

diff --git a/lsx.c b/lsx.c
index fd28625..e5b5c0b 100644
--- a/lsx.c
+++ b/lsx.c
@@ -30,10 +30,9 @@ lsx(const char *dir) {
 		perror(dir);
 		return;
 	}
-	while((d = readdir(dp))) {
-		snprintf(buf, sizeof buf, "%s/%s", dir, d->d_name);
-		if(!stat(buf, &st) && S_ISREG(st.st_mode) && access(buf, X_OK) == 0)
+	while((d = readdir(dp)))
+		if(snprintf(buf, sizeof buf, "%s/%s", dir, d->d_name) < sizeof buf
+		&& !stat(buf, &st) && S_ISREG(st.st_mode) && access(buf, X_OK) == 0)
 			puts(d->d_name);
-	}
 	closedir(dp);
 }