From: Quentin Rameau <quinq@fifth.space>
Date: Sun, 22 Nov 2015 14:19:10 +0000 (+0100)
Subject: Modify decideresource() and favicon handling
X-Git-Url: https://git.danieliu.xyz/?a=commitdiff_plain;h=c3a827d621fbedfb974db9d137d3e5bea66490b4;p=surf.git

Modify decideresource() and favicon handling

Return as soon as the request has been processed.
No need to modify the favicon uri, just ignore it.
---

diff --git a/surf.c b/surf.c
index 1f3b7db..f5c7d1e 100644
--- a/surf.c
+++ b/surf.c
@@ -1143,10 +1143,10 @@ decideresource(WebKitPolicyDecision *d, Client *c)
 	    webkit_response_policy_decision_get_response(r);
 	const gchar *uri = webkit_uri_response_get_uri(res);
 
-	if (g_str_has_suffix(uri, "/favicon.ico"))
-		webkit_uri_request_set_uri(
-		    webkit_response_policy_decision_get_request(r),
-		    "about:blank");
+	if (g_str_has_suffix(uri, "/favicon.ico")) {
+		webkit_policy_decision_ignore(d);
+		return;
+	}
 
 	if (!g_str_has_prefix(uri, "http://")
 	    && !g_str_has_prefix(uri, "https://")
@@ -1164,6 +1164,7 @@ decideresource(WebKitPolicyDecision *d, Client *c)
 		if (isascii) {
 			handleplumb(c, uri);
 			webkit_policy_decision_ignore(d);
+			return;
 		}
 	}