use array for items

[dmenu.git] / dmenu.c

diff --git a/dmenu.c b/dmenu.c
index 3c83d73..2684c91 100644 (file)
--- a/dmenu.c
+++ b/dmenu.c
@@ -1,4 +1,4 @@
-/* See LICENSE file for copyright and license details. */
+/* See LICENSE file for copynext and license details. */
 #include <ctype.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -19,8 +19,7 @@
 typedef struct Item Item;
 struct Item {
        char *text;
-       Item *next;          /* traverses all items */
-       Item *left, *right;  /* traverses matching items */
+       Item *left, *right;
 };
 
 static void appenditem(Item *item, Item **list, Item **last);
@@ -386,7 +385,7 @@ match(void) {
 
        len = strlen(text);
        matches = lexact = lprefix = lsubstr = itemend = exactend = prefixend = substrend = NULL;
-       for(item = items; item; item = item->next)
+       for(item = items; item && item->text; item++)
                if(!fstrncmp(text, item->text, len + 1))
                        appenditem(item, &lexact, &exactend);
                else if(!fstrncmp(text, item->text, len))
@@ -445,16 +444,17 @@ paste(void) {
 void
 readstdin(void) {
        char buf[sizeof text], *p;
-       Item *item, **end;
+       size_t i, size = 0;
 
-       for(end = &items; fgets(buf, sizeof buf, stdin); *end = item, end = &item->next) {
+       for(i = 0; fgets(buf, sizeof buf, stdin); items[++i].text = NULL) {
+               if(i+1 == size / sizeof *items || !items)
+                       if(!(items = realloc(items, (size += BUFSIZ))))
+                               eprintf("cannot realloc %u bytes:", size);
                if((p = strchr(buf, '\n')))
                        *p = '\0';
-               if(!(item = calloc(1, sizeof *item)))
-                       eprintf("cannot malloc %u bytes:", sizeof *item);
-               if(!(item->text = strdup(buf)))
+               if(!(items[i].text = strdup(buf)))
                        eprintf("cannot strdup %u bytes:", strlen(buf)+1);
-               inputw = MAX(inputw, textw(dc, item->text));
+               inputw = MAX(inputw, textw(dc, items[i].text));
        }
 }
 
@@ -506,18 +506,18 @@ setup(void) {
        mh = (lines + 1) * bh;
 #ifdef XINERAMA
        if((info = XineramaQueryScreens(dc->dpy, &n))) {
-               int i, m, di;
+               int i, di;
                unsigned int du;
                Window dw;
 
                XQueryPointer(dc->dpy, root, &dw, &dw, &x, &y, &di, &di, &du);
-               for(i = 0, m = -1; i < n; i++)
+               for(i = 0; i < n-1; i++)
                        if((monitor == info[i].screen_number)
-                       || (m < 0 && INRECT(x, y, info[i].x_org, info[i].y_org, info[i].width, info[i].height)))
-                               m = i;
-               x = info[m].x_org;
-               y = info[m].y_org + (topbar ? 0 : info[m].height - mh);
-               mw = info[m].width;
+                       || (monitor < 0 && INRECT(x, y, info[i].x_org, info[i].y_org, info[i].width, info[i].height)))
+                               break;
+               x = info[i].x_org;
+               y = info[i].y_org + (topbar ? 0 : info[i].height - mh);
+               mw = info[i].width;
                XFree(info);
        }
        else