Small bugfix for makeglyphfontspecs call in drawregion
authorsuigin <suigin@national.shitposting.agency>
Sat, 9 May 2015 22:22:40 +0000 (15:22 -0700)
committerRoberto E. Vargas Caballero <k0ga@shike2.com>
Tue, 12 May 2015 05:37:13 +0000 (07:37 +0200)
Here's a patch that fixes a bug when calling `makedrawglyphfontspecs'
in `drawregion'. Wasn't offseting the pointer into the input glyphs
array by `x1'. The bug isn't causing any problems currently, because
`drawregion' is always called with `x1' and `y1' values of 0, but if
this ever changes in the future, the bug would certainly cause some
problems.

st.c

diff --git a/st.c b/st.c
index c2da66b..73fe291 100644 (file)
--- a/st.c
+++ b/st.c
@@ -3663,7 +3663,7 @@ drawregion(int x1, int y1, int x2, int y2) {
                term.dirty[y] = 0;
 
                specs = term.specbuf;
-               numspecs = xmakeglyphfontspecs(specs, &term.line[y][0], x2 - x1, x1, y);
+               numspecs = xmakeglyphfontspecs(specs, &term.line[y][x1], x2 - x1, x1, y);
 
                i = ox = 0;
                for(x = x1; x < x2 && i < numspecs; x++) {