tresize: move for loop outside if
authornoname@inventati.org <noname@inventati.org>
Sat, 11 Apr 2015 17:29:52 +0000 (19:29 +0200)
committerRoberto E. Vargas Caballero <k0ga@shike2.com>
Mon, 13 Apr 2015 07:21:03 +0000 (09:21 +0200)
There is no need to check that slide > 0 before executing loop.
If slide <= 0, loop stops immediately.

st.c

diff --git a/st.c b/st.c
index 4ed8319..fb37eb5 100644 (file)
--- a/st.c
+++ b/st.c
@@ -2780,17 +2780,16 @@ tresize(int col, int row) {
        }
 
        /* free unneeded rows */
-       i = 0;
+       for(i = 0; i < slide; i++) {
+               free(term.line[i]);
+               free(term.alt[i]);
+       }
        if(slide > 0) {
                /*
                 * slide screen to keep cursor where we expect it -
                 * tscrollup would work here, but we can optimize to
                 * memmove because we're freeing the earlier lines
                 */
-               for(/* i = 0 */; i < slide; i++) {
-                       free(term.line[i]);
-                       free(term.alt[i]);
-               }
                memmove(term.line, term.line + slide, row * sizeof(Line));
                memmove(term.alt, term.alt + slide, row * sizeof(Line));
        }