Update XIM cursor position only if changed
authorIvan Tham <pickfire@riseup.net>
Sun, 19 Apr 2020 17:38:39 +0000 (19:38 +0200)
committerHiltjo Posthuma <hiltjo@codemadness.org>
Sun, 19 Apr 2020 17:39:48 +0000 (19:39 +0200)
Updating XIM cursor position is expensive, so only update it when cursor
position changed.

st.c

diff --git a/st.c b/st.c
index 9e568c6..0ce6ac2 100644 (file)
--- a/st.c
+++ b/st.c
@@ -2571,6 +2571,7 @@ void
 drawregion(int x1, int y1, int x2, int y2)
 {
        int y;
 drawregion(int x1, int y1, int x2, int y2)
 {
        int y;
+
        for (y = y1; y < y2; y++) {
                if (!term.dirty[y])
                        continue;
        for (y = y1; y < y2; y++) {
                if (!term.dirty[y])
                        continue;
@@ -2583,7 +2584,7 @@ drawregion(int x1, int y1, int x2, int y2)
 void
 draw(void)
 {
 void
 draw(void)
 {
-       int cx = term.c.x;
+       int cx = term.c.x, ocx = term.ocx, ocy = term.ocy;
 
        if (!xstartdraw())
                return;
 
        if (!xstartdraw())
                return;
@@ -2599,9 +2600,11 @@ draw(void)
        drawregion(0, 0, term.col, term.row);
        xdrawcursor(cx, term.c.y, term.line[term.c.y][cx],
                        term.ocx, term.ocy, term.line[term.ocy][term.ocx]);
        drawregion(0, 0, term.col, term.row);
        xdrawcursor(cx, term.c.y, term.line[term.c.y][cx],
                        term.ocx, term.ocy, term.line[term.ocy][term.ocx]);
-       term.ocx = cx, term.ocy = term.c.y;
+       term.ocx = cx;
+       term.ocy = term.c.y;
        xfinishdraw();
        xfinishdraw();
-       xximspot(term.ocx, term.ocy);
+       if (ocx != term.ocx || ocy != term.ocy)
+               xximspot(term.ocx, term.ocy);
 }
 
 void
 }
 
 void